Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get rid of s3 resoure and data source #973

Merged
merged 1 commit into from
Mar 8, 2021

Conversation

ShiChangkuo
Copy link
Collaborator

@ShiChangkuo ShiChangkuo commented Mar 5, 2021

What this PR does / why we need it:

Which issue this PR fixes:
(optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged)
fixes #xxx

Special notes for your reviewer:

Release note:

the huaweicloud_s3_* resource and data source have marked as
deprecated since v1.17.0, use huaweicloud_obs_* instead.

PR Checklist

  • Tests added/passed.
  • Documentation updated.
  • Schema updated.

Acceptance Steps Performed

$ make testacc TEST='./huaweicloud' TESTARGS='-run TestAccObsBucket'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./huaweicloud -v -run TestAccObsBucket -timeout 360m -parallel 4
=== RUN   TestAccObsBucketObject_source
=== PAUSE TestAccObsBucketObject_source
=== RUN   TestAccObsBucketObject_content
=== PAUSE TestAccObsBucketObject_content
=== RUN   TestAccObsBucketPolicy_basic
=== PAUSE TestAccObsBucketPolicy_basic
=== RUN   TestAccObsBucketPolicy_update
=== PAUSE TestAccObsBucketPolicy_update
=== RUN   TestAccObsBucketPolicy_s3
=== PAUSE TestAccObsBucketPolicy_s3
=== RUN   TestAccObsBucket_basic
=== PAUSE TestAccObsBucket_basic
=== RUN   TestAccObsBucket_withEpsId
=== PAUSE TestAccObsBucket_withEpsId
=== RUN   TestAccObsBucket_tags
=== PAUSE TestAccObsBucket_tags
=== RUN   TestAccObsBucket_versioning
=== PAUSE TestAccObsBucket_versioning
=== RUN   TestAccObsBucket_logging
=== PAUSE TestAccObsBucket_logging
=== RUN   TestAccObsBucket_quota
=== PAUSE TestAccObsBucket_quota
=== RUN   TestAccObsBucket_lifecycle
=== PAUSE TestAccObsBucket_lifecycle
=== RUN   TestAccObsBucket_website
=== PAUSE TestAccObsBucket_website
=== RUN   TestAccObsBucket_cors
=== PAUSE TestAccObsBucket_cors
=== CONT  TestAccObsBucketObject_source
=== CONT  TestAccObsBucket_versioning
=== CONT  TestAccObsBucketPolicy_s3
=== CONT  TestAccObsBucket_tags
--- PASS: TestAccObsBucket_tags (12.99s)
=== CONT  TestAccObsBucket_withEpsId
    provider_test.go:150: This environment does not support EPS_ID tests
--- SKIP: TestAccObsBucket_withEpsId (0.00s)
=== CONT  TestAccObsBucket_basic
--- PASS: TestAccObsBucketPolicy_s3 (16.78s)
=== CONT  TestAccObsBucket_website
--- PASS: TestAccObsBucketObject_source (22.56s)
=== CONT  TestAccObsBucket_cors
--- PASS: TestAccObsBucket_versioning (24.84s)
=== CONT  TestAccObsBucket_quota
--- PASS: TestAccObsBucket_basic (19.10s)
=== CONT  TestAccObsBucket_lifecycle
--- PASS: TestAccObsBucket_cors (13.81s)
=== CONT  TestAccObsBucketPolicy_basic
--- PASS: TestAccObsBucket_quota (12.88s)
=== CONT  TestAccObsBucketPolicy_update
--- PASS: TestAccObsBucket_website (21.78s)
=== CONT  TestAccObsBucket_logging
--- PASS: TestAccObsBucket_lifecycle (11.95s)
=== CONT  TestAccObsBucketObject_content
--- PASS: TestAccObsBucketPolicy_basic (14.88s)
--- PASS: TestAccObsBucket_logging (19.86s)
--- PASS: TestAccObsBucketPolicy_update (23.21s)
--- PASS: TestAccObsBucketObject_content (22.96s)
PASS
ok      github.com/huaweicloud/terraform-provider-huaweicloud/huaweicloud       67.066s

the huaweicloud_s3_* resource and data source have marked as
deprecated since v1.17.0, use huaweicloud_obs_* instead.
@ShiChangkuo ShiChangkuo requested a review from niuzhenguo March 5, 2021 10:30
@ShiChangkuo ShiChangkuo merged commit a16a693 into huaweicloud:master Mar 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant